netdev
[Top] [All Lists]

Re: [PATCH] new net device feature: shared-ipv6-cards

To: kuznet@xxxxxxxxxxxxx
Subject: Re: [PATCH] new net device feature: shared-ipv6-cards
From: "Andreas Herrmann" <AHERRMAN@xxxxxxxxxx>
Date: Wed, 21 Aug 2002 19:00:39 +0200
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx, owner-netdev@xxxxxxxxxxx, pekkas@xxxxxxxxxx
Sender: owner-netdev@xxxxxxxxxxx
      kuznet@xxxxxxxxxxxxx
      Sent by: owner-netdev@xxxxxxxxxxx
      08/21/02 05:55 PM

  > One thought: if you have to add a new field to struct netdevice,
  > it makes lots of sense to move further and to add special method
  > dev->generate_eui64() instead, which will be initialized
  > to standard eth_generate_eui64() for normal ethernets
  > and to something private for your device.

I agree with this. Of course this implies changes in the device driver
itself. (Currently our device driver for the shared cards relies on
the changes described in the patch.)
But its the way it should be done.

  > In this way we are guaranteed not to have problems of this kind
  > in future.

What about implementing your alternative proposal in 2.5 and to use
the current approach in a next 2.4.x kernel?


Regards,

Andreas

--
Linux for eServer Development
Tel :  +49-7031-16-4640
Notes mail :  Andreas Herrmann/GERMANY/IBM@IBMDE
email :  aherrman@xxxxxxxxxx



<Prev in Thread] Current Thread [Next in Thread>