netdev
[Top] [All Lists]

Re: [PATCH] minor socket ioctl cleanup for 2.5.30

To: Matthew Wilcox <willy@xxxxxxxxxx>
Subject: Re: [PATCH] minor socket ioctl cleanup for 2.5.30
From: James Morris <jmorris@xxxxxxxxxxxxxxxx>
Date: Fri, 9 Aug 2002 03:46:05 +1000 (EST)
Cc: kuznet@xxxxxxxxxxxxx, <davem@xxxxxxxxxx>, <netdev@xxxxxxxxxxx>
In-reply-to: <20020808184206.Q24631@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
On Thu, 8 Aug 2002, Matthew Wilcox wrote:

> this patch is for information purposes only, right?  ;-)

Yes.

> > +long f_getown(struct file *filp)
> > +{
> > +   return filp->f_owner.pid;
> > +}
> 
> i still think this function shouldn't exist -- a direct reference is
> no problem.

Agreed.

> 
> 
> > +                   f_setown(filp, arg);

> this is now hooked by the LSM folks so patch will need to be updated for
> 2.5.30.

Yep, a more recent version of this patch consolidates the LSM 
file_set_fowner hook into f_setown().


- James
-- 
James Morris
<jmorris@xxxxxxxxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>