netdev
[Top] [All Lists]

Re: [PATCH] minor socket ioctl cleanup for 2.5.30

To: kuznet@xxxxxxxxxxxxx
Subject: Re: [PATCH] minor socket ioctl cleanup for 2.5.30
From: Matthew Wilcox <willy@xxxxxxxxxx>
Date: Thu, 8 Aug 2002 18:17:17 +0100
Cc: Matthew Wilcox <willy@xxxxxxxxxx>, davem@xxxxxxxxxx, jmorris@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <200208081713.VAA02896@xxxxxxxxxxxxx>; from kuznet@xxxxxxxxxxxxx on Thu, Aug 08, 2002 at 09:13:15PM +0400
References: <20020808170720.N24631@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <200208081713.VAA02896@xxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
On Thu, Aug 08, 2002 at 09:13:15PM +0400, kuznet@xxxxxxxxxxxxx wrote:
> No, this is not true. This creepy ioctl is specific to TCP
> (well, x.25 also uses SIGURG), which use kill*(sk->proc, SIGURG) directly.
> 
> Probably, it is better to move sk->proc to TCP private data,
> this ioctl to tcp_ioctl(). Or... find a way to get rid of this completely,
> not breaking compatibility with a few BSDish applications.

jamesm also has patches which remove sk->proc altogether and make TCP
use the normal fasync methods.  this ioctl then does an f_setown and
most of the creepiness is gone.  consider this patch a stepping-stone.

-- 
Revolutions do not require corporate support.


<Prev in Thread] Current Thread [Next in Thread>