netdev
[Top] [All Lists]

Re: [RFC] SNMP_ADD_STATS

To: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Subject: Re: [RFC] SNMP_ADD_STATS
From: Andi Kleen <ak@xxxxxxx>
Date: Thu, 13 Jun 2002 02:11:19 +0200
Cc: "David S.Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20020612182348.GP1073@xxxxxxxxxxxxxxxx>
References: <20020612182348.GP1073@xxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Mutt/1.3.22.1i
> #define IP_ADD_STATS(field,incr) SNMP_ADD_STATS(ip_statistics, field, incr)
> 
> Any objections?

Better use per_cpu data in 2.5 (<asm/percpu.h>) for the MIBs.

That's much more efficient on some architectures, uses less memory on all
and is also cleaner.

-Andi

<Prev in Thread] Current Thread [Next in Thread>