Re: [PATCH] Make netfilter handle SACK in NAT'ed connections (was Re: Fw: oops/bug in tcp, SACK doesn't work?)

[kuznet@xxxxxxxxxxxxx]

Hello!

> The only question remaining is:  Is it worth the effort?  What do the
> core linux developers think? 

What's about me, I think it is required. There are no reasons to drop sacks,
when you already have code to mangle data.

About complexity... does not matter, "complexity" happens when something
is logically not quite trivial. SACK mangling is just straight hand work
rather than complexity. It is even not long looking at the patch. :-)

Unlike timestamps. Timestamps are better to delete even when not mangling.


BTW what is this?

                        /* Half a match?  This means a partial retransmisison.
                           It's a cracker being funky. */

>From code I cannot guess, what does it mean. Does this mean that NAT can
block some valid data?

Alexey