netdev
[Top] [All Lists]

Re: netdev.stats change suggestion

To: Chris Wedgwood <cw@xxxxxxxx>
Subject: Re: netdev.stats change suggestion
From: Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx>
Date: Thu, 24 Jan 2002 06:24:22 -0500
Cc: Dmitrii Tisnek <dima@xxxxxxxxx>, netdev@xxxxxxxxxxx
Organization: MandrakeSoft
References: <Pine.OSF.4.30.0201231450280.15676-100000@xxxxxxxxxxx> <20020124112023.GA31956@xxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
Chris Wedgwood wrote:
> 
> On Wed, Jan 23, 2002 at 03:02:14PM +0200, Dmitrii Tisnek wrote:
> 
>     I've discovered that struct net_device_stats defines counters like
>     rx_bytes and tx_bytes as unsigned long, which on x86 is, sadly, 32
>     bits.
> 
> How fast is our IO?  For most everyone, 32-bits is plenty enough.
> Have a daemon/whatever check it from time-to-time and detect overflow.

We should make them 64-bit because related SNMP MIBs use 64-bits.

        Jeff




-- 
Jeff Garzik      | "I went through my candy like hot oatmeal
Building 1024    |  through an internally-buttered weasel."
MandrakeSoft     |             - goats.com

<Prev in Thread] Current Thread [Next in Thread>