netdev
[Top] [All Lists]

Re: [PATCH] make rt_intern_hash() don't search yet another time on UP

To: kuznet@xxxxxxxxxxxxx
Subject: Re: [PATCH] make rt_intern_hash() don't search yet another time on UP
From: Martin Josefsson <gandalf@xxxxxxxxxxxxxx>
Date: Sat, 19 Jan 2002 20:55:18 +0100 (CET)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <200201191922.WAA32142@xxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
On Sat, 19 Jan 2002 kuznet@xxxxxxxxxxxxx wrote:

> Hello!

Hi,

> > rt_intern_hash() isn't needed on UP AFAIK.
> 
> Did you notice that route_slow works with enabled softirqs?

Hmm can you explain this in more detail please?
I didn't think a new softirq that was scheduled by a interrupthandler
could "preempt" a running softirq if that's what you mean.

I certainly see why that extra lookup is needed on SMP but I can't
really see why it's needed on UP.

> > -   rthp = &rt_hash_table[hash].chain;
> 
> It is not dereference.

Gah, you are correct. (I think I need some coffee :)

/Martin

Never argue with an idiot. They drag you down to their level, then beat you 
with experience.


<Prev in Thread] Current Thread [Next in Thread>