netdev
[Top] [All Lists]

Re: [PATCH][RFC 2] cleaning up struct sock

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: [PATCH][RFC 2] cleaning up struct sock
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date: Tue, 18 Dec 2001 23:22:22 -0200
Cc: SteveW@xxxxxxx, jschlst@xxxxxxxxx, ncorbic@xxxxxxxxxxx, eis@xxxxxxxxxxxxx, dag@xxxxxxxxxxx, torvalds@xxxxxxxxxxxxx, marcelo@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20011218.130809.22018359.davem@xxxxxxxxxx>
Mail-followup-to: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, SteveW@xxxxxxx, jschlst@xxxxxxxxx, ncorbic@xxxxxxxxxxx, eis@xxxxxxxxxxxxx, dag@xxxxxxxxxxx, torvalds@xxxxxxxxxxxxx, marcelo@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
References: <20011218033552.B910@xxxxxxxxxxxxxxxx> <20011217.225134.91313099.davem@xxxxxxxxxx> <20011218185200.A1211@xxxxxxxxxxxxxxxx> <20011218.130809.22018359.davem@xxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Mutt/1.3.23i
Em Tue, Dec 18, 2001 at 01:08:09PM -0800, David S. Miller escreveu:
>    From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
>    > What kind of before/after effect do you see in lat_tcp/lat_connect
>    > (from lmbench) runs?
>    
>    Improvements on the lat_connect case? :)
>    
> Great.  I have no fundamental problems with your changes.

Ok, I assume that these changes will get integrated in 2.5 then, does anybody
disagree? Holler now or forever hold your peace (tm) Linus. 8)
 
> Now, when/if we move the hash-chain/identity members into
> the IPv4 struct (there are some issues with this wrt. ipv6 btw) I will
> be interested in seeing the same tests done :-)

I tried it but had problems with incoming connections not being stablished,
and you said that you preferred that it stayed there, on the first
cacheline, so I preferred to submit the patch without that and after this
gets integrated and more widely tested in 2.5 I'll revisit this issue and
try again, trying to look into these issues with IPv6 you've mentioned,
BTW, could you elaborate on that? :)

Now to the next tasks: dedicate some more time to finish the LLC stack for
2.4 and move on to cleanup struct inode (fs.h) for 2.5.

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>