| To: | Ingo Molnar <mingo@xxxxxxx> |
|---|---|
| Subject: | Re: [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5 |
| From: | jamal <hadi@xxxxxxxxxx> |
| Date: | Wed, 3 Oct 2001 20:44:30 -0400 (EDT) |
| Cc: | Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, Robert Olsson <Robert.Olsson@xxxxxxxxxxx>, <bcrl@xxxxxxxxxx>, <netdev@xxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> |
| In-reply-to: | <Pine.LNX.4.33.0110031853220.8633-100000@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | owner-netdev@xxxxxxxxxxx |
On Wed, 3 Oct 2001, Ingo Molnar wrote: > i like this approach very much, and indeed this is not polling in any way. > > i'm worried by the dev->quota variable a bit. As visible now in the > 2.4.10-poll.pat and tulip-NAPI-010910.tar.gz code, it keeps calling the > ->poll() function until dev->quota is gone. I think it should only keep > calling the function until the rx ring is fully processed - and it should > re-enable the receiver afterwards, when exiting net_rx_action. This would result in an unfairness. Think of one device which receives packets really fast that it takes most of the CPU capacity just processing it. cheers, jamal |
| Previous by Date: | Re: [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5, Andreas Dilger |
|---|---|
| Next by Date: | Re: [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5, jamal |
| Previous by Thread: | Re: [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5, Ingo Molnar |
| Next by Thread: | Re: [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5, Ingo Molnar |
| Indexes: | [Date] [Thread] [Top] [All Lists] |