netdev
[Top] [All Lists]

Re: [PATCH] ioctl SIOCGIFNETMASK: ip alias bug 2.4.9 and 2.2.19

To: tao@xxxxxxxxxx, matthias.andree@xxxxxx
Subject: Re: [PATCH] ioctl SIOCGIFNETMASK: ip alias bug 2.4.9 and 2.2.19
From: kuznet@xxxxxxxxxxxxx
Date: Mon, 10 Sep 2001 23:36:20 +0400 (MSK DST)
Cc: alan@xxxxxxxxxxxxxxxxxxx, wietse@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20010910100537.W26627@xxxxxxxxxxxxxxx> from "David Weinehall" at Sep 10, 1 10:05:37 am
Sender: owner-netdev@xxxxxxxxxxx
Hello!

> a bad idea after all. Whining about this causing "bloat and maintainance

Listen, let's close this thread. :-)

The patch sent by Matthias is enough small not to speak about some bloat.


And I see no reasons to refuse this: it evidently improves the things
almost without efforts. No matter that this imporvement is not so useful,
as it would happen if I guessed this way from the very beginning.
So that applications will have to worry about compatibility with older
kernels in any case.


(BTW Matthias, while applying it to my tree, I noticed that
it does not check for SIOGGIFNETMASK. It would be better to do this only
when it is meaningful: I see only SIOGGIFNETMASK and SIOGGIFBROADCAST).

Alexey

<Prev in Thread] Current Thread [Next in Thread>