netdev
[Top] [All Lists]

Re: notion of a local address [was: Re: ioctl SIOCGIFNETMASK: ip aliasbu

To: Andrey Savochkin <saw@xxxxxxxxxxxxx>
Subject: Re: notion of a local address [was: Re: ioctl SIOCGIFNETMASK: ip aliasbug 2.4.9 and 2.2.19]
From: Julian Anastasov <ja@xxxxxx>
Date: Fri, 7 Sep 2001 13:02:12 +0000 (GMT)
Cc: <netdev@xxxxxxxxxxx>
In-reply-to: <20010907134829.A28196@xxxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
        Hello,

On Fri, 7 Sep 2001, Andrey Savochkin wrote:

> >             key.src = res.fi->fib_prefsrc ?: key.dst;
> >
> >     key.dst is != 0, so, we don't need to call FIB_RES_PREFSRC
> > and inet_select_addr, we prefer key.dst as source.
>
> Yes, something like this.
> I only wonder why there is a check `if (res.fi)' several lines below and
> whether !res.fi can really happen in this place.
> After that FIB_RES_PREFSRC is used without any precautions.

        It seems fib_lookup returns valid fi, 0 is not possible. I'm
wondering what else we break except autofs, for local routes with
prefixlen!=32, I don't know who uses the current "feature" :)

>       Andrey

Regards

--
Julian Anastasov <ja@xxxxxx>


<Prev in Thread] Current Thread [Next in Thread>