netdev
[Top] [All Lists]

Re: [PATCH] RFC: fix ethernet device initialization

To: Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] RFC: fix ethernet device initialization
From: Jes Sorensen <jes@xxxxxxxxxxxxx>
Date: 08 Mar 2001 18:35:54 +0100
Cc: Linux Knernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: Jeff Garzik's message of "Wed, 07 Mar 2001 16:17:36 -0500"
References: <3AA6A570.57FF2D36@xxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Gnus/5.070096 (Pterodactyl Gnus v0.96) Emacs/20.4
>>>>> "Jeff" == Jeff Garzik <jgarzik@xxxxxxxxxxxxxxxx> writes:

Jeff> People from time to time point out a wart in ethernet
Jeff> initialization: The net_device is allocated and registered to
Jeff> the system in init_etherdev, which is usually one of the first
Jeff> things an ethernet driver probe function does.  The net_device's
Jeff> final members are setup at some time between then and the exit
Jeff> of the probe function.  There is never a clear point where the
Jeff> net device is available to the system for use.

I don't like the way you declare all the code in obscure macros in
there.

+#define DECLARE_CHG_MTU(suffix,low,high) \
+       static int suffix##_change_mtu(struct net_device *dev, int new_mtu) \
......

All it does is to make the code harder to read and debug for little/no
gain.

Jes

<Prev in Thread] Current Thread [Next in Thread>