netdev
[Top] [All Lists]

Re: [Fwd: Re: possible bug x86 2.4.2 SMP in IP receive stack]

To: Bob Felderman <feldy@xxxxxxxx>
Subject: Re: [Fwd: Re: possible bug x86 2.4.2 SMP in IP receive stack]
From: jamal <hadi@xxxxxxxxxx>
Date: Mon, 5 Mar 2001 19:25:26 -0500 (EST)
Cc: <andrewm@xxxxxxxxxx>, <kuznet@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>
In-reply-to: <200103060000.QAA21285@xxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
Now this is the problem with proprietary drivers that nobody sees the code
for (or maybe hardware that nobody sees specs for)
You caused people all the pain of trying to decode what your problem is
only to find you are making some basic mistakes.
There was a document URL posted on how to write drivers with the new 2.4
kernel (here on netdev). Look up the archive.

Sorry, nothing personal here. But this is where Open Source might have
benefited you.


cheers,
jamal


On Mon, 5 Mar 2001, Bob Felderman wrote:

> => From andrewm@xxxxxxxxxx Mon Mar  5 15:50:15 2001
> => Your driver doesn't appear to have any SMP locking.  The
> => same skb can be fed to the network stack twice.
>
> The driver does (and always has had)
>
>     if (test_and_set_bit(0, (void *) &is->arch.interrupt) != 0) {
>               /* hmm, interrupt called twice */
>               [other stuff deleted]
>       }
>


<Prev in Thread] Current Thread [Next in Thread>