From: Jes Sorensen <jes@xxxxxxxxxxxxx>
Date: 08 Jan 2001 22:56:48 +0100
I don't think it's too much to ask that one actually tries to
communicate with an author of a piece of code before making such
major changes and submitting them opting for inclusion in the
kernel.
Jes, I have not submitted this for inclusion into the kernel.
This is the "everyone, including driver authors, take a look"
part of the development process.
We _had_ to change some drivers to show how to support this
new SKB api for transmit sg+csum support. If you can think of
a way for us to effectively do this work without changing at least a
few drivers as examples (and proof of concept), please let us know.
In the process we hit real bugs in your driver, and tried to deal
with them as best we could so that we could continue testing and
debugging our own code.
As a side note, as much as you may hate some of Alexey's changes to
your driver, several things he does fixes long standing real bugs in
the Acenic driver that you've been papering over with workarounds
for quite some time. I would even go so far as to say that in many
regards Alexey understands the Acenic much better than you, and you
would be wise to work with Alexey and not against him. Thanks.
Later,
David S. Miller
davem@xxxxxxxxxx
|