netdev
[Top] [All Lists]

Re: [PATCH] hashed device lookup (Does NOT meet Linus' sumission policy!

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [PATCH] hashed device lookup (Does NOT meet Linus' sumission policy!)
From: Chris Wedgwood <cw@xxxxxxxx>
Date: Mon, 8 Jan 2001 19:12:09 +1300
Cc: "David S. Miller" <davem@xxxxxxxxxx>, david@xxxxxxxxx, greearb@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20010108063214.A29026@xxxxxxxxxxxxxxxxxxx>; from ak@xxxxxxx on Mon, Jan 08, 2001 at 06:32:14AM +0100
References: <20010107162905.B1804@xxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.10.10101070220410.4173-100000@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20010108011308.A2575@xxxxxxxxxxxxxxxxxxx> <200101071201.EAA01790@xxxxxxxxxxxxxxx> <20010108063214.A29026@xxxxxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Mon, Jan 08, 2001 at 06:32:14AM +0100, Andi Kleen wrote:

    I think it would be better to keep it. The ifa based alias
    interface emulation adds minor overhead (currently it's only a
    few lines of code, assuming we need named if addresses for other
    reasons too, which we do) and removing it it would break a lot of
    configuration scripts etc., for no really good gain.

It's ugly and deceptive -- eth0:0 is _not_ a separate device to eth0,
so why pretend it is?

Yes, FIXING this wart will break stuff, that is part of the reason we
have development cycles. Applications that break need fixing anyhow,
as DaveM says BSD support multiple addresses per interface anyhow, so
perhaps not many applications will break at all -- I've not really
checked.

2.5.x seems like an excellent time to FIX this. I guess the final
decision is that of DaveM and Alexey.



  --cw (These are mine opinions alone, but they should be everyones)

<Prev in Thread] Current Thread [Next in Thread>