netdev
[Top] [All Lists]

Re: alignment issues on netif_rx

To: Kai Germaschewski <kai@xxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: alignment issues on netif_rx
From: Andi Kleen <ak@xxxxxx>
Date: Fri, 15 Dec 2000 17:15:47 +0100
Cc: netdev@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.10.10012151332190.32035-100000@xxxxxxxxxxxx uni-duesseldorf.de>; from kai@xxxxxxxxxxxxxxxxxxxxxxxx on Fri, Dec 15, 2000 at 01:43:21PM +0100
References: <Pine.LNX.4.10.10012151332190.32035-100000@xxxxxxxxxxxx uni-duesseldorf.de>
Sender: owner-netdev@xxxxxxxxxxx
On Fri, Dec 15, 2000 at 01:43:21PM +0100, Kai Germaschewski wrote:
> 
> Some people are planning to use the ISDN code in the linux kernel on their
> MIPS port.
> 
> They ran into some problems with alignment, and use the following patch to
> fix their problems.

Aligning data is the driver's responsibility.

The kernel should not fail though even when it is misaligned, only be slow
because of misalignment traps. This is needed because the driver can not 
always predict for all cases (e.g. EthernetII and 802.3 require different
alignment to get aligned TCP/IP), so it should optimize for the common
case. 

(if that is not true on mips then it is a mips bug) 

-Andi


<Prev in Thread] Current Thread [Next in Thread>