Re: BUG in tcp.c ?

[kuznet@xxxxxxxxxxxxx]

Hello!

> If I understood correctly, the code relies on that GFP_BUFFER allocations
> will not sleep, right ? 

No, really. This branch is used exactly from one place and
we may sleep there.

I am afraid not of this, but that it is too agressive.
The idea was to get high order chunk of memory (32K as rule),
if memory is not under pressure. And if it is a problem,
allocate small page sized buffer using sk->allocation.

This code is very old. I suspect it is not valid now.
Maybe it should use GFP_NULL = 0. 8)

Alexey