Re: PATCH 2.4.0.9.2: export ethtool interface

[Andi Kleen <ak@xxxxxx>]

On Mon, Oct 02, 2000 at 07:11:44PM +0200, A.N.Kuznetsov wrote:
> Hello!
> 
> > > However, I have to remind that open/close/ioctl __are__ serialized
> > > with global semaphore.
> > > 
> > > To Andi: BKL is fully useless here, just because these calls are allowed
> > > to sleep.
> > 
> > Of course it can sleep, in this case they have to lock themselves. With the
> > BKL it would at least not be worse than in 2.2.
> 
> Did you read something but the last sentence? 8)8)
> 
> 2.4 _did_ _not_ change anything here. BKL was equally useless in 2.2.

I guess we're talking about different things again. I was worrying
about the ioctls not being reentrant against themselves, not against the
RX/TX threads in interrupts. 

This is e.g. the case with PPP ioctls calling into the tty layer.



-Andi

-- 
This is like TV. I don't like TV.