Hello!
> Can we add an argument for nfmark field in ip_route_output()? Needed
> so local traffic can be routed in complex ways (mark altered in
> NF_IP_LOCAL_OUT).
To say is that I dislike this is to say nothing.
If you have an skb to reroute, reroute skb.
If you do not want to depend on skb, add new function using
rt_key as argument. You may even replace ip_route_output()
with this new function everywhere, it will be a bit slower,
but it is worth to do, because has lots of useful applications
not bound to nfmark.
But adding new argument (and with such name, which cries to be
#ifdef'd) to function used mainly in context, where there
are no way to set something but zero is strange idea.
> The other option is less invasive: make route_me_harder call
> ip_route_output_slow() directly, and simply add the parameter there.
But why did you select _more_ invasive way then? 8)
I can answer to myself. It is easy to see from name of this function,
look at it more carefully.
Alexey
|