netdev
[Top] [All Lists]

Re: modular net drivers, take 2

To: Andi Kleen <ak@xxxxxx>
Subject: Re: modular net drivers, take 2
From: Andrew Morton <andrewm@xxxxxxxxxx>
Date: Wed, 21 Jun 2000 00:42:41 +0000
Cc: "netdev@xxxxxxxxxxx" <netdev@xxxxxxxxxxx>
References: <394F5E62.DE02F835@xxxxxxxxxx>, <394F5E62.DE02F835@xxxxxxxxxx>; from Andrew Morton on Tue, Jun 20, 2000 at 02:04:35PM +0200 <20000620173857.A4089@xxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
Andi Kleen wrote:
> 
> On Tue, Jun 20, 2000 at 02:04:35PM +0200, Andrew Morton wrote:
> >
> > - sys_ioctl() and sys_delete_module() both already claim
> >   the big lock, so where's the race anyway?  I feel I'm missing
> >   something..
> 
> Ugh, I missed that. Ok, with that there is no race. Even better :-)

I think I lied.  Look at this:

int sock_ioctl(...)
{
    struct socket *sock;
    int err;

    unlock_kernel();
    sock = socki_lookup(inode);
    err = sock->ops->ioctl(sock, cmd, arg);
    lock_kernel();
                                                                                
   
return err;
}

<Prev in Thread] Current Thread [Next in Thread>