Re: tx_timeout and timer serialisation

[kuznet@xxxxxxxxxxxxx]

Hello!

> Get rid of the braindead timer_exit() macro, and inside
> run_timer_list, do:
> 
> #ifdef CONFIG_SMP
>       if (timer->function(timer->data)) {
>               timer->running = 0;
>               mb();
>       }
> #else
>       timer->function(timer->data);
> #endif

I apologize. Certainly it could look like.

        if (timer->flags & TIMER_SELF_DESTRUCTABLE) {
                timer->function(timer->data);
                timer->running = 0;
                mb();
        } else {
                timer->function(timer->data);
        }


But both ways are still wrong. We still need macro telling,
when a self-destructable timer is running even if we need not
any synchronization. So that timer_exit() is required in any case.

Alexey