netdev
[Top] [All Lists]

Re: [PATCH]: Cruft fixes

To: Andi Kleen <ak@xxxxxx>
Subject: Re: [PATCH]: Cruft fixes
From: jamal <hadi@xxxxxxxxxx>
Date: Sat, 20 May 2000 13:37:13 -0400 (EDT)
Cc: davem@xxxxxxxxxx, kuznet@xxxxxxxxxxxxx, SteveW@xxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20000520102352.A4219@xxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx

Thanks Andi, Please ignore the patch; I'll send a fresh one later
which i'll probably get killed for ;->
We shall see.

cheers,
jamal
 
On Sat, 20 May 2000, Andi Kleen wrote:

> On Sat, May 20, 2000 at 04:23:31AM +0200, jamal wrote:
> > 
> > 
> > This patch removes a bit of cruft.  Please double check.
> 
> Sorry, my original judgement was wrong. The RX path uses it to distingush
> between old protocols that don't support SMP multithreading yet and new
> multithreaded protocols.  Unfortunately this breaks the fastroute packet 
> socket detection hack as you noted.
> 
> The right fix is to add a flag word to packet_type that distingushes
> packet sockets and non locked protocols, and use that instead of the
> overloaded data member. Such a flag word would fit nicely between
> type and dev, there should be a 2 bytes gap there anyways.
> 
> 
> -Andi
> 


<Prev in Thread] Current Thread [Next in Thread>