Re: [PATCH] Move shaper control information into skb->cb

["David S. Miller" <davem@xxxxxxxxxx>]

   Date: Mon, 24 Apr 2000 23:46:23 +0200
   From: Andi Kleen <ak@xxxxxx>

   This moves the shaper local data into the skb->cb struct, removing
   ugly ifdefs from the sk_buff. I also documented the purpose of 
   the control buffer better. For 2.3.x.

I really like this.

Just one question, did you verify that this won't clobber CB data
used by whoever generated the packet?  Just say yes, and if I see
no other objections I'll put this into the tree.

I know intuitively that once, for example, tcp_transmit_skb has
built the TCP header the control block can be clobbered by any
further usage.  We should really document this, at least in a
comment above that function.

Sounds like something which would be nice to audit in our tree.

Later,
David S. Miller
davem@xxxxxxxxxx