netdev
[Top] [All Lists]

Re: bug: 3c509 broken on 2.3.48

To: Michael Clark <mclark@xxxxxxxxxxxxxxxxxxx>
Subject: Re: bug: 3c509 broken on 2.3.48
From: Bill Wendling <wendling@xxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 2 Mar 2000 14:21:36 -0600
Cc: root <root@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <38BE3341.79D4A80B@xxxxxxxxxxxxxxxxxxx>; from mclark@xxxxxxxxxxxxxxxxxxx on Thu, Mar 02, 2000 at 10:24:17PM +1300
References: <20000302102603.A1091@xxxxxxxxxxxxxxxxxx> <20000302015357.A10322@xxxxxxxxxxxxxxxxxxxxxx> <38BE3341.79D4A80B@xxxxxxxxxxxxxxxxxxx>
Sender: owner-netdev@xxxxxxxxxxx
Also sprach Michael Clark:
} This patch was sent. Also fixed NE2000 clone for me. I'm surprised more
} net drivers were not broken - 2.3.47 had some big net changes with
} drivers checking link state differently.
} 
} Has someone got this patch into 2.3.49?
} 
} ~mc
} 
} Tim Waugh wrote:
} > 
} > On Sun, 27 Feb 2000, Pete Clements wrote:
} > 
} > > FYI:
} > > With both 2.3.47 and 48, unable to up the 3c509 driver when compiled
} > > into the kernel.  Works fine when compiled as module.
} > 
} > Does this patch help?
} > 
} > Tim.
} > */
} > 
} > --- linux/net/core/dev.c~       Sun Feb 27 17:53:51 2000
} > +++ linux/net/core/dev.c        Sun Feb 27 17:54:06 2000
} > @@ -2128,6 +2128,7 @@
} >                                 dev->iflink = dev->ifindex;
} >                         if (dev->rebuild_header == NULL)
} >                                 dev->rebuild_header = 
default_rebuild_header;
} > +                       set_bit(__LINK_STATE_PRESENT, &dev->state);
} >                         dev_init_scheduler(dev);
} >                 }
} >         }
} 
This is in the 2.3.49pre2 kernel. I didn't see it before. Sorry. However,
the sequence of instructions is 

                        dev_init_scheduler(dev);
                        set_bit(__LINK_STATE_PRESENT, &dev->state);

which I"m hoping is okay...

-- 
|| Bill Wendling                        wendling@xxxxxxxxxxxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>