netdev
[Top] [All Lists]

Bug in recent net driver skeleton ?

To: becker@xxxxxxxxxxxxxxxxxxxx
Subject: Bug in recent net driver skeleton ?
From: Andi Kleen <ak@xxxxxx>
Date: Fri, 26 Nov 1999 06:18:21 +0100
Cc: netdev@xxxxxxxxxxx
Sender: owner-netdev@xxxxxxxxxxx
Hallo Donald,

The recent ethernet drivers of yours (3c59x 0.99L, tulip 0.91g2,
eepro100 etc.) have this line:

#if (LINUX_VERSION_CODE >= 0x20100)
char kernel_version[] = UTS_RELEASE;
#endif

Now this breaks when I try to compile multiple of these drivers statically
into a kernel. The linker rightfully complains about multiple definitions
of kernel_version. I think the right fix is to change it into:

#if defined(MODULE) && (LINUX_VERSION_CODE >= 0x20100)
char kernel_version[] = UTS_RELEASE;
#endif

kernel_version makes no sense without a module anyways. Or is there some
deep reason I'm missing?

-Andi


<Prev in Thread] Current Thread [Next in Thread>