<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="font-family:arial,sans-serif">On Tue, May 10, 2016 at 8:10 AM, Dave Chinner </span><span dir="ltr" style="font-family:arial,sans-serif"><<a href="mailto:david@fromorbit.com" target="_blank">david@fromorbit.com</a>></span><span style="font-family:arial,sans-serif"> wrote:</span></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span class=""><br>
</span>Looking at xfstests runs, new failures are:<br>
<br>
generic/054 -<br>
generic/055 - both fail with:<br>
<br>
+*** mkfs failed: -l version=2,su=4096 ***<br>
<br>
and the .full file has this specific error:<br>
<br>
Illegal value 4096 for -l su option. value is too small<br>
<br>
indicating that we should be allowing (2^N * block size) log<br>
stripe units to be set. This will be a limit configuration issue,<br>
most likely needing fixing in mkfs.<br></blockquote><div><br></div><div><div class="gmail_default"><font face="arial, helvetica, sans-serif">I'm looking on it, but this issue was introduced by Eric's fix for patch </font>"mkfs: table based parsing for converted parameters":</div></div><br><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">> </div>The kernel enforces a max of XLOG_MAX_RECORD_BSIZE,<br><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">> </div>and it should match the limits in L_SUNIT after all ...</div><div class="gmail_quote"><br></div><div class="gmail_quote"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">And looking on fs/xfs/xfs_super.c, the MIN value is enforced too. So maybe it is the test what needs fixing? Otherwise, I would put something like XFS_MIN_SECTORSIZE there.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">See <a href="http://lxr.free-electrons.com/source/fs/xfs/xfs_super.c#L435">http://lxr.free-electrons.com/source/fs/xfs/xfs_super.c#L435</a></div></div><div class="gmail_quote"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
xfs/096 6s ... - output mismatch (see /home/dave/src/xfstests-dev/results//xfs/xfs/096.out.bad)<br>
--- tests/xfs/096.out 2016-04-05 11:11:36.814382107 +1000<br>
+++ /home/dave/src/xfstests-dev/results//xfs/xfs/096.out.bad 2016-05-10 12:54:25.956199714 +1000<br>
@@ -2,18 +2,62 @@<br>
<br>
# su too big but must be a multiple of fs block size too<br>
--- mkfs=-l version=2,su=262656 ---<br>
-log stripe unit (262656) must be a multiple of the block size (4096)<br>
+Illegal value 262656 for -l su option. value is too large<br>
+Usage: mkfs.xfs<br>
+/* blocksize */ [-b log=n|size=num]<br>
...<br>
(Run 'diff -u tests/xfs/096.out /home/dave/src/xfstests-dev/results//xfs/xfs/096.out.bad' to see the entire diff)<br>
<br>
This test is explicitly testing an invalid value, checking that it<br>
falls back to a sane default. This patchset has changed the<br>
behaviour, so the xfstest will need some rework to handle both old<br>
and new mkfs behaviour.<br>
<br>
Can you send patches to fix all these up?<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">Sure.</div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">Jan</div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"></div> </div></div><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Jan Tulak<br></div><a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a> / <a href="mailto:jan@tulak.me" target="_blank">jan@tulak.me</a></div></div></div></div>
</div></div>