<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="font-family:arial,sans-serif">On Thu, Apr 7, 2016 at 1:02 AM, Eric Sandeen </span><span dir="ltr" style="font-family:arial,sans-serif"><<a href="mailto:sandeen@sandeen.net" target="_blank">sandeen@sandeen.net</a>></span><span style="font-family:arial,sans-serif"> wrote:</span><br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 3/24/16 6:15 AM, <a href="mailto:jtulak@redhat.com">jtulak@redhat.com</a> wrote:<br>
> From: Dave Chinner <<a href="mailto:dchinner@redhat.com">dchinner@redhat.com</a>><br>
><br>
> CHANGELOG<br>
> o Fix an unsigned < 0 comparison - save getnum result to another variable<br>
> and test it, before converting it to unsigned logagno.<br>
<br>
</span>...<br>
<span class=""><br>
> @@ -1468,7 +1485,10 @@ main(<br>
> respec('l', lopts, L_AGNUM);<br>
> if (ldflag)<br>
> conflict('l', lopts, L_AGNUM, L_DEV);<br>
> - logagno = atoi(value);<br>
> + tmp_num = getnum(value, 0, 0, false);<br>
> + if (tmp_num < 0)<br>
> + illegal(value, "l agno");<br>
> + logagno = (xfs_agnumber_t)tmp_num;<br>
> laflag = 1;<br>
> break;<br>
> case L_FILE:<br>
<br>
</span>Why not cast to (__int64_t) like other variables do? i.e.<br>
<br>
<br>
+ logagno = getnum(value, 0, 0, false);<br>
+ if ((__int64_t)logagno < 0)<br>
<span class="">+ illegal(value, "l agno");<br>
<br>
</span>or am I missing something?<br>
<br></blockquote><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Nothing I'm aware of. Replaced.</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks,<br>
-Eric<br>
<div class="HOEnZb"><div class="im trimless-h5 trimless-content"><br>
_______________________________________________<br>
xfs mailing list<br>
<a href="mailto:xfs@oss.sgi.com">xfs@oss.sgi.com</a><br>
<a href="http://oss.sgi.com/mailman/listinfo/xfs" rel="noreferrer" target="_blank">http://oss.sgi.com/mailman/listinfo/xfs</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Jan Tulak<br></div><a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a> / <a href="mailto:jan@tulak.me" target="_blank">jan@tulak.me</a></div></div></div></div>
</div></div>