<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="font-family:arial,sans-serif">On Wed, Sep 23, 2015 at 5:32 AM, Dave Chinner </span><span dir="ltr" style="font-family:arial,sans-serif"><<a href="mailto:david@fromorbit.com" target="_blank">david@fromorbit.com</a>></span><span style="font-family:arial,sans-serif"> wrote:</span><br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Sep 15, 2015 at 11:59:21AM +0200, Jan Tulak wrote:<br>
> Simply rename statvfs64 to statfs with a #define.<br>
> OSX version of statvfs is missing some members, so if the renaming<br>
> is in effect (stavfs64 is defined), don't try to use them and go<br>
> directly for the other member value.<br>
><br>
> Signed-off-by: Jan Tulak <<a href="mailto:jtulak@redhat.com">jtulak@redhat.com</a>><br>
> ---<br>
>  fsr/xfs_fsr.c        | 14 ++++++++++++++<br>
>  include/<a href="http://builddefs.in" rel="noreferrer" target="_blank">builddefs.in</a> |  2 +-<br>
>  include/darwin.h     |  5 +++++<br>
>  3 files changed, 20 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c<br>
> index e1b7bd6..5f95cdc 100644<br>
> --- a/fsr/xfs_fsr.c<br>
> +++ b/fsr/xfs_fsr.c<br>
> @@ -36,6 +36,12 @@<br>
>  #  include <mntent.h><br>
>  #endif<br>
><br>
> +#ifdef __APPLE__<br>
> +//#  define statvfs64 statfs;<br>
> +#  include <sys/param.h><br>
> +#  include <sys/mount.h><br>
> +#endif<br>
<br>
</span>Why is this here? We've included libxfs.h in this file, so we've<br>
got access to the platform specific includes already, and later in<br>
the patch you put the commented out define there...<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">​Most likely because I messed it in a rebase during some conflict. I try to check for these things, but apparently this one escaped. Removing it again​..</div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></div></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks for catching it.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Cheers,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Jan</div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Jan Tulak<br></div><a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a> / <a href="mailto:jan@tulak.me" target="_blank">jan@tulak.me</a></div></div></div></div>
</div></div>