<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="font-family:arial,sans-serif">On Wed, Sep 23, 2015 at 5:15 AM, Dave Chinner </span><span dir="ltr" style="font-family:arial,sans-serif"><<a href="mailto:david@fromorbit.com" target="_blank">david@fromorbit.com</a>></span><span style="font-family:arial,sans-serif"> wrote:</span><br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>On Tue, Sep 15, 2015 at 11:59:14AM +0200, Jan Tulak wrote:<br>
> WILL CHANGE THE COMMIT MESSAGE.<br>
<br>
</span>OK? </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>
> All right, I make the renaming with define - though I'm not sure<br>
> that with the ifdef for OS X and SIZE_MAX moved to a standalone patch<br>
> we need it - shouldn't be this change rather dropped?<br>
><br>
> Signed-off-by: Jan Tulak <<a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a>><br>
> ---<br>
>  include/xfs.h      | 2 ++<br>
>  libhandle/handle.c | 4 ++--<br>
>  libhandle/jdm.c    | 4 ++--<br>
>  3 files changed, 6 insertions(+), 4 deletions(-)<br>
><br>
> diff --git a/include/xfs.h b/include/xfs.h<br>
> index bc94068..8ee0106 100644<br>
> --- a/include/xfs.h<br>
> +++ b/include/xfs.h<br>
> @@ -53,6 +53,8 @@<br>
>  # define ASSERT(EX)  ((void) 0)<br>
>  #endif<br>
><br>
> +#define XFS_XATTR_LIST_MAX XATTR_LIST_MAX<br>
> +<br>
<br>
</span>This does not belong here - it is a limit that applies to the ioctl<br>
API and so must be the same in userspace and the kernel. Such<br>
definitions belong in libxfs/xfs_fs.h, and should respect local OS<br>
limits if defined. e.g. something like:<br>
<br>
#ifdef XATTR_LIST_MAX<br>
#define XFS_XATTR_LIST_MAX XATTR_LIST_MAX<br>
#else<br>
#define XFS_XATTR_LIST_MAX 65536<br>
#endif<br>
<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">​OK, ​that makes sense.</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Will work on both the kernel and userspace side. This will also need<br>
a kernel side patch...</blockquote><div><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">​Now, this is something where I may need a bit help/confirmation, I guess.​</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">What I suppose I should do is:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">1) Clone linux-xfs (git://<a href="http://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs.git" target="_blank">git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs.git</a>)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">2) Edit linux-xfs/fs/xfs/libxfs/xfs_fs.h and add the same change there</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">3) Send it to this mailing list as usual, with "[PATCH] xfs: ..."</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">(The same goes for the other patch with the kernel need too.)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Is it all right? Correct repository URL? :-)</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Jan</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div>Jan Tulak<br></div><a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a> / <a href="mailto:jan@tulak.me" target="_blank">jan@tulak.me</a></div></div></div></div>
</div></div>