<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
--- a/estimate/xfs_estimate.c<br>
+++ b/estimate/xfs_estimate.c<br>
@@ -168,7 +168,7 @@ main(int argc, char **argv)<br>
                ndirs=0LL;              /* number of directories */<br>
                nspecial=0LL;           /* number of special files */<br>
<br>
-               nftw64(argv[optind], ffn, 40, FTW_PHYS | FTW_MOUNT);<br>
+               nftw(argv[optind], ffn, 40, FTW_PHYS | FTW_MOUNT);<br>
<br>
                if (__debug) {<br>
                        printf(_("dirsize=%llu\n"), dirsize);<br>
<span class=""><font color="#888888">--<br>
2.4.5<br>
<br></font></span></blockquote><div> </div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">​Now I noticed this causes a warning:</div></div><div><div class="gmail_default" style="display:inline"><font face="arial, helvetica, sans-serif">xfs_estimate.c:171:3: warning: passing argument 2 of ‘nftw’ from incompatible pointer type</font><br></div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">From ftw.h, the difference is in __nftw_func_t and __nftw64_func_t as a second argument. However, what we pass in the code is "</div><font face="arial, helvetica, sans-serif">int<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">​ ​</div></font><span style="font-family:arial,helvetica,sans-serif">ffn(<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">​..., struct stat64 *stb, ...)". ​If I change this to struct stat, it works and xfstests -g quick gives the same result as with 64bit variant. So I'm sending an updated patch.</div></span></div><div><span style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></span></div><div><span style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">Cheers,</div></span></div><div><span style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">Jan</div></span></div><div><span style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></span></div><div><span style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></span></div><div><span style="font-family:arial,helvetica,sans-serif"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></span></div></div><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Jan Tulak<br></div><a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a> / <a href="mailto:jan@tulak.me" target="_blank">jan@tulak.me</a></div></div></div></div>
</div></div>