<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Ah, never mind, I noticed I didn't read the last part of Dave's email. It looks clear now.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Jan</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 1, 2015 at 10:13 AM, Jan Tulak <span dir="ltr"><<a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="h5"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><span style="font-family:arial,sans-serif">On Mon, Aug 31, 2015 at 8:58 PM, Christoph Hellwig </span><span dir="ltr" style="font-family:arial,sans-serif"><<a href="mailto:hch@infradead.org" target="_blank">hch@infradead.org</a>></span><span style="font-family:arial,sans-serif"> wrote:</span><br></div></div></div><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span>> index b1c0c10..d532f44 100644<br>
> --- a/libhandle/handle.c<br>
> +++ b/libhandle/handle.c<br>
> @@ -21,6 +21,8 @@<br>
>  #include "xfs.h"<br>
>  #include "handle.h"<br>
>  #include "parent.h"<br>
> +#include "xfs/xfs_arch.h"<br>
> +#include "xfs/xfs_format.h"<br>
<br>
</span>These headers should not be used in libhandle.  As mentioned last time I<br>
think libhandle should get it's own LIBHANDLE_XATTR_LIST_MAX define,<br>
separate frome the one for the on disk format.<br></blockquote><div><br></div></div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">​Well, you wrote about adding it into xfs_format.h. I don't recall (and can't find) anything else regarding XATTR_SIZE... </div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></div><span style="color:rgb(80,0,80);font-size:12.8000001907349px">> Eww, looks like we depend on these Linux values in the on disk</span><br style="color:rgb(80,0,80);font-size:12.8000001907349px"><span style="color:rgb(80,0,80);font-size:12.8000001907349px">> defintion.  I think we need to add new XFS_XATTR_SIZE_MAX and</span><br style="color:rgb(80,0,80);font-size:12.8000001907349px"><span style="color:rgb(80,0,80);font-size:12.8000001907349px">> XFS_XATTR_LIST_MAX defintions to xfs_format.h and use them where</span><br style="color:rgb(80,0,80);font-size:12.8000001907349px"><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><span style="color:rgb(80,0,80);font-size:12.8000001907349px;font-family:arial,sans-serif">> we currently use these.</span></div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">So ​</div> <div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline">​the XFS_ defines in xfs_format​.h should be there, I just need to add another LIBHANDLE_ variant so we don't include the headers, right?</div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;display:inline"><br></div></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">​Cheers,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Jan​</div><br></div></div><span class=""><br><br clear="all"><div><br></div>-- <br><div><div dir="ltr"><div><div dir="ltr"><div>Jan Tulak<br></div><a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a> / <a href="mailto:jan@tulak.me" target="_blank">jan@tulak.me</a></div></div></div></div>
</span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Jan Tulak<br></div><a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a> / <a href="mailto:jan@tulak.me" target="_blank">jan@tulak.me</a></div></div></div></div>
</div>