<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Aug 17, 2015 at 9:39 PM, Christoph Hellwig <span dir="ltr"><<a href="mailto:hch@infradead.org" target="_blank">hch@infradead.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Mon, Aug 17, 2015 at 06:23:26PM +0200, Jan Tulak wrote:<br>
> UPDATE: default to "signature found", so without blkid is<br>
>         -f mandatory.<br>
<br>
</span>Belongs in the cover letter, not this patch.<br></blockquote><div><br></div><div>I forgot to remove it from the patch, sorry for that.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><br>
>               } else<br>
>                       ft->psectorsize = ft->lsectorsize = BBSIZE;<br>
>       } else {<br>
> +#ifdef ENABLE_BLKID<br>
>               blkid_get_topology(dfile, &ft->dsunit, &ft->dswidth,<br>
>                                  &ft->lsectorsize, &ft->psectorsize,<br>
>                                  force_overwrite);<br>
> +#endif /* ENABLE_BLKID */<br>
>       }<br>
><br>
>       if (xi->rtname && !xi->risfile) {<br>
>               int sunit, lsectorsize, psectorsize;<br>
><br>
> +#ifdef ENABLE_BLKID<br>
>               blkid_get_topology(xi->rtname, &sunit, &ft->rtswidth,<br>
>                                  &lsectorsize, &psectorsize, force_overwrite);<br>
> +#endif /* ENABLE_BLKID */<br>
<br>
</span>I think you need to proide a dummy blkid_get_topology which at least<br>
sets the two sector sizes to 512.<br></blockquote><div><br></div><div>I don't think so. blkid_get_topology is used only for block devices, not</div><div>when mkfs-ing a file. And there are multiple further issues with mkfs</div><div>on OS X with system calls, so such dummy call would be for no use.</div><div><br></div><div>Although, when I think about it, removing few ifdef would certainly make the code</div><div>cleaner, so I think I can make a dummy call for this reason. </div><div><br></div><div>Cheers,</div><div>Jan</div><div><br></div></div>-- <br><div><div dir="ltr"><div>Jan Tulak<br></div><a href="mailto:jtulak@redhat.com" target="_blank">jtulak@redhat.com</a><br></div></div>
</div></div>