<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 28, 2014 at 10:56 PM, Eric Sandeen <span dir="ltr"><<a href="mailto:sandeen@sandeen.net" target="_blank">sandeen@sandeen.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">On 3/28/14, 3:03 AM, Dan Carpenter wrote:<br>
> There were some extra semi-colons here which mean that we return true<br>
> unintentionally.<br>
><br>
> Fixes: a49935f200e2 ('xfs: xfs_check_page_type buffer checks need help')<br>
<br>
</div>that's terrifying.<br></blockquote><div>Wonder how errors like this one get into the kernel :-) Suppose it's not the main tree, but instead xfs private one.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

<br>
Reviewed-by: Eric Sandeen <<a href="mailto:sandeen@redhat.com">sandeen@redhat.com</a>><br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

<div class="im"><br>
> Signed-off-by: Dan Carpenter <<a href="mailto:dan.carpenter@oracle.com">dan.carpenter@oracle.com</a>><br>
><br>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c<br>
> index 98016b3..75df77d 100644<br>
> --- a/fs/xfs/xfs_aops.c<br>
> +++ b/fs/xfs/xfs_aops.c<br>
> @@ -659,10 +659,10 @@ xfs_check_page_type(<br>
>                       if (type == XFS_IO_UNWRITTEN)<br>
>                               return true;<br>
>               } else if (buffer_delay(bh)) {<br>
> -                     if (type == XFS_IO_DELALLOC);<br>
> +                     if (type == XFS_IO_DELALLOC)<br>
>                               return true;<br>
>               } else if (buffer_dirty(bh) && buffer_mapped(bh)) {<br>
> -                     if (type == XFS_IO_OVERWRITE);<br>
> +                     if (type == XFS_IO_OVERWRITE)<br>
>                               return true;<br>
>               }<br>
><br>
><br>
</div><div class="im">> _______________________________________________<br>
> xfs mailing list<br>
> <a href="mailto:xfs@oss.sgi.com">xfs@oss.sgi.com</a><br>
> <a href="http://oss.sgi.com/mailman/listinfo/xfs" target="_blank">http://oss.sgi.com/mailman/listinfo/xfs</a><br>
><br>
<br>
</div><div class=""><div class="h5">--<br>
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in<br>
the body of a message to <a href="mailto:majordomo@vger.kernel.org">majordomo@vger.kernel.org</a><br>
More majordomo info at  <a href="http://vger.kernel.org/majordomo-info.html" target="_blank">http://vger.kernel.org/majordomo-info.html</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Raphael S. Carvalho
</div></div>