<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 02/10/2014 11:04 PM, Dave Chinner wrote:<br>
<blockquote cite="mid:20140210220400.GV13647@dastard" type="cite">
<pre wrap="">On Mon, Feb 10, 2014 at 10:39:22PM +0100, Koen De Wit wrote:
</pre>
<blockquote type="cite">
<pre wrap="">+
+_test_illegal_leafsize() {
+ _scratch_mkfs -l $1 >>$seqres.full 2>&1
+ [ $? -ne 0 ] || _fail "'$1' is an illegal value for the" \
+ "leafsize option, mkfs should have failed."
+}
</pre>
</blockquote>
<pre wrap="">
You just re-implemented run_check....
</pre>
</blockquote>
<br>
I believe I didn't :<br>
<blockquote>run_check()<br>
{<br>
echo "# $@" >> $seqres.full 2>&1<br>
"$@" >> $seqres.full 2>&1 || _fail "failed:
'$@'"<br>
}<br>
</blockquote>
run_check() takes an arbitrary command and executes it,
_test_illegal_leafsize() takes a leafsize as parameter and tries
mkfs.btrfs with that leafsize. run_check() makes the test fail if
the return code is not zero, _test_illegal_leafsize() does the
opposite.<br>
<br>
Thanks,<br>
Koen.<br>
</body>
</html>