<html><body><div>Kodiak Furr liked your message with <a href="http://ad.apps.fm/x3NHJParL2cT9cQ9WcgT1xM8G1T_LUvoWYXredpuoYBLq62ptJqsuhqD23uAmN_ARL_cKzXIyDOjqo_2b16qX20uaphnFWU7uPwUiYWuOATFUAGQB7Cox3TWT3ZKjzWyPFIlhepnEZcRklQejqpibw">Boxer</a>.</div><br/><br/><div><div class="quote">On January 29, 2014 at 3:43:59 PM CST, Eric Sandeen <esandeen@redhat.com> wrote:<br/><blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-left:0px;padding-left:10px;">On 1/29/14, 3:38 PM, Theodore Ts'o wrote:<br />> On Wed, Jan 29, 2014 at 03:45:02PM -0500, Eric Whitney wrote:<br />>> ext4/306 will fail when mounting the ext3 file system it creates if an<br />>> ext3-incompatible mount option is applied by _scratch_mount. This can<br />>> happen if EXT_MOUNT_OPTIONS is defined appropriately in the test<br />>> environment. For example, the block_validity option is commonly used<br />>> to enhance ext4 testing, and it is not supported by ext3. Fix this by<br />>> not including any mount options defined by the test environment.<br />> <br />> I'm not sure I understand why the test is insisting that the file<br />> system be mounted using ext3. If the file system is created without<br />> the extents flag, all of the files will be created using indirect<br />> blocks, and fundamentally what this test is getting at is that after<br />> we grow the file system using resize2fs, the new blocks are available<br />> to be allocated and attached to an indirect block file.<br />> <br />> We can do this by using ext4; I'm not sure why this test is trying to<br />> use ext3 to set up the test flie system. It might be better to get<br />> rid of the requirement to create the file system using ext3, since it<br />> will make the test runnable even if the ext3 file system hasn't been<br />> configured into the system and CONFIG_EXT23_AS_EXT4 is not enabled.<br />> <br />> IIRC, Eric Sandeen wrote this test --- Eric, am I missing some reason<br />> why it was necessary to use ext3 here?<br /><br />Nope. Tomayto, tomahto - I think the original report had trouble with<br />an ext3 filesystem, so that's how I wrote the testcase.<br /><br />It could be fixed either way, I think.<br /><br />-Eric<br /><br />> <br />> - Ted<br />> <br /><br />--<br />To unsubscribe from this list: send the line "unsubscribe linux-ext4" in<br />the body of a message to majordomo@vger.kernel.org<br />More majordomo info at http://vger.kernel.org/majordomo-info.html<br /></blockquote></div></div></body></html>