<div dir="ltr"><div style="font-family:arial,sans-serif;font-size:13px">In the current check script the -g option assumes only one group is given. With this patch, the -g option </div><div style="font-family:arial,sans-serif;font-size:13px">
understands comma separated multiple groups as the argument as well. Existing scripts are not affected </div><div style="font-family:arial,sans-serif;font-size:13px">by this patch. </div><div style="font-family:arial,sans-serif;font-size:13px">
<br></div><div style="font-family:arial,sans-serif;font-size:13px">Reviewed-by: Dave Chinner <<a href="mailto:david@redhat.com">david@redhat.com</a>></div><div style="font-family:arial,sans-serif;font-size:13px">Signed-off-by: Itaru Kitayama <<a href="mailto:itaru.kitayama@gmail.com" target="_blank">itaru.kitayama@gmail.com</a>></div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">---</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">
 check |   23 ++++++++++++-----------</div><div style="font-family:arial,sans-serif;font-size:13px"> 1 file changed, 12 insertions(+), 11 deletions(-)</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div>
<div style="font-family:arial,sans-serif;font-size:13px">diff --git a/check b/check</div><div style="font-family:arial,sans-serif;font-size:13px">index a79747e..0e0f208 100755</div><div style="font-family:arial,sans-serif;font-size:13px">
--- a/check</div><div style="font-family:arial,sans-serif;font-size:13px">+++ b/check</div><div style="font-family:arial,sans-serif;font-size:13px">@@ -164,18 +164,19 @@ while [ $# -gt 0 ]; do</div><div style="font-family:arial,sans-serif;font-size:13px">
        -nfs)   FSTYP=nfs ;;</div><div style="font-family:arial,sans-serif;font-size:13px"> </div><div style="font-family:arial,sans-serif;font-size:13px">        -g)     group=$2 ; shift ;</div><div style="font-family:arial,sans-serif;font-size:13px">
-               group_list=$(get_group_list $group)</div><div style="font-family:arial,sans-serif;font-size:13px">-               if [ -z "$group_list" ]; then</div><div style="font-family:arial,sans-serif;font-size:13px">
-                   echo "Group \"$group\" is empty or not defined?"</div><div style="font-family:arial,sans-serif;font-size:13px">-                   exit 1</div><div style="font-family:arial,sans-serif;font-size:13px">
-               fi</div><div style="font-family:arial,sans-serif;font-size:13px">-</div><div style="font-family:arial,sans-serif;font-size:13px">-               [ ! -s $tmp.list ] && touch $tmp.list</div><div style="font-family:arial,sans-serif;font-size:13px">
-               for t in $group_list; do</div><div style="font-family:arial,sans-serif;font-size:13px">-                       grep -s "^$t\$" $tmp.list >/dev/null || \</div><div style="font-family:arial,sans-serif;font-size:13px">
-                                                       echo "$t" >>$tmp.list</div><div style="font-family:arial,sans-serif;font-size:13px">+               for g in ${group//,/ }; do</div><div style="font-family:arial,sans-serif;font-size:13px">
+                       group_list=$(get_group_list $g)</div><div style="font-family:arial,sans-serif;font-size:13px">+                       if [ -z "$group_list" ]; then</div><div style="font-family:arial,sans-serif;font-size:13px">
+                       echo "Group \"$g\" is empty or not defined?"</div><div style="font-family:arial,sans-serif;font-size:13px">+                       exit 1</div><div style="font-family:arial,sans-serif;font-size:13px">
+                       fi</div><div style="font-family:arial,sans-serif;font-size:13px">+               </div><div style="font-family:arial,sans-serif;font-size:13px">+                       [ ! -s $tmp.list ] && touch $tmp.list</div>
<div style="font-family:arial,sans-serif;font-size:13px">+                       for t in $group_list; do</div><div style="font-family:arial,sans-serif;font-size:13px">+                               grep -s "^$t\$" $tmp.list >/dev/null || \</div>
<div style="font-family:arial,sans-serif;font-size:13px">+                                                               echo "$t" >>$tmp</div><div style="font-family:arial,sans-serif;font-size:13px">+                       done</div>
<div style="font-family:arial,sans-serif;font-size:13px">                done</div><div style="font-family:arial,sans-serif;font-size:13px">-</div><div style="font-family:arial,sans-serif;font-size:13px">                ;;</div>
<div style="font-family:arial,sans-serif;font-size:13px"> </div><div style="font-family:arial,sans-serif;font-size:13px">        -x)     xgroup=$2 ; shift ;</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, May 21, 2013 at 9:45 AM, Dave Chinner <span dir="ltr"><<a href="mailto:david@fromorbit.com" target="_blank">david@fromorbit.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Mon, May 20, 2013 at 08:42:35PM +0900, Itaru Kitayama wrote:<br>
> Yes, we can do that, but I just thought as you originally proposed last year<br>
><br>
> -g rw,attr reads better.<br>
<br>
</div>Agreed, it does read better and is easily to type.<br>
<br>
That's what you need to put in the commit message - why it is better<br>
than what we currently have, and whether it is badwards compatible<br>
or not (doesn't break any existing scripts). i.e. the commit<br>
message is for telling people -why- the change should be made as we<br>
can look at the code to determine -what- the change is.  ;)<br>
<div class="HOEnZb"><div class="h5"><br>
Cheers,<br>
<br>
Dave.<br>
--<br>
Dave Chinner<br>
<a href="mailto:david@fromorbit.com">david@fromorbit.com</a><br>
</div></div></blockquote></div><br></div>