<div dir="ltr">Hi,<br><br>this patch introduced a regression as it is no longer possible to install xfstests to non-standard directory. The install-sh script that is packed with xfstests supports DIST_ROOT variable for installation to non-standard directory and hence, the command<br>
<br>make DIST_ROOT=/some/other/dir<br><br>worked well before the change. However now, even though libtootl actually calls the install-sh script, the libtool itself also checks that the given installation directory exists. Since the libtool does not respect DIST_ROOT, then unless you already have xfstests installed in /var/lib/xfstets, the installation with DIST_ROOT variable will fail with<br>
<br>libtool: install: `/var/lib/xfstests/ltp' is not a directory<br><br>Looking at the libtool script, there does not seem to be a nice way to fix this since it checks that the destination directory exists directly by command 'test -d "$dest".<br>
<br>Hence, possible workarounds include creating xfstests directory structure in /var/lib/xfstest/ before installing to DEST_DIR or reverting this patch. Looking at the libtool --mode=install --help, the command should also support -inst-prefix $DEST_DIR but that did not work in my case (and looking at the source code of libtool script, it does not treat the -inst-prefix option specially in install mode).<br>
<br>Regrads,<br>Boris<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 28, 2012 at 7:26 PM, Rich Johnston <span dir="ltr"><<a href="mailto:rjohnston@sgi.com" target="_blank">rjohnston@sgi.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch replaces the INSTALL macro with LTINSTALL so that libtool is used<br>
to install the applications. Libtool will install the binary from the proper<br>
location and display a warning if any shared library dependancies are not<br>
properly installed. This ensures that a libtool wrapper shell script is not<br>
installed in place of application when libtool wrappers are being used.<br>
<br>
<br>
Signed-off-by: Rich Johnston <<a href="mailto:rjohnston@sgi.com">rjohnston@sgi.com</a>><br>
<br>
---<br>
ltp/Makefile | 2 +-<br>
src/Makefile | 6 +++---<br>
2 files changed, 4 insertions(+), 4 deletions(-)<br>
<br>
Index: b/ltp/Makefile<br>
===================================================================<br>
--- a/ltp/Makefile<br>
+++ b/ltp/Makefile<br>
@@ -44,7 +44,7 @@ $(TARGETS): $(LIBTEST)<br>
<br>
install: default<br>
$(INSTALL) -m 755 -d $(PKG_LIB_DIR)/ltp<br>
- $(INSTALL) -m 755 $(TARGETS) $(PKG_LIB_DIR)/ltp<br>
+ $(LTINSTALL) -m 755 $(TARGETS) $(PKG_LIB_DIR)/ltp<br>
$(INSTALL) -m 755 $(SCRIPTS) $(PKG_LIB_DIR)/ltp<br>
<br>
-include .dep<br>
Index: b/src/Makefile<br>
===================================================================<br>
--- a/src/Makefile<br>
+++ b/src/Makefile<br>
@@ -74,9 +74,9 @@ LINKTEST = $(LTLINK) $@.c -o $@ $(CFLAGS<br>
<br>
install: default $(addsuffix -install,$(SUBDIRS))<br>
$(INSTALL) -m 755 -d $(PKG_LIB_DIR)/src<br>
- $(INSTALL) -m 755 $(TARGETS) $(PKG_LIB_DIR)/src<br>
- $(INSTALL) -m 755 fill2attr fill2fs fill2fs_check scaleread.sh $(PKG_LIB_DIR)/src<br>
- $(INSTALL) -m 644 dumpfile $(PKG_LIB_DIR)/src<br>
+ $(LTINSTALL) -m 755 $(TARGETS) $(PKG_LIB_DIR)/src<br>
+ $(LTINSTALL) -m 755 fill2attr fill2fs fill2fs_check scaleread.sh $(PKG_LIB_DIR)/src<br>
+ $(LTINSTALL) -m 644 dumpfile $(PKG_LIB_DIR)/src<br>
<br>
%-install:<br>
$(MAKE) -C $* install<br>
<br>
_______________________________________________<br>
xfs mailing list<br>
<a href="mailto:xfs@oss.sgi.com">xfs@oss.sgi.com</a><br>
<a href="http://oss.sgi.com/mailman/listinfo/xfs" target="_blank">http://oss.sgi.com/mailman/listinfo/xfs</a><br>
</blockquote></div><br></div>