[PATCH 04/14] xfs: reorder zeroing and flushing sequence in truncate
Bob Peterson
rpeterso at redhat.com
Thu May 5 12:34:50 CDT 2016
----- Original Message -----
> Currently zeroing out blocks and waiting for writeout is a bit of a mess in
> truncate. This patch gives it a clear order in preparation for the iomap
> path:
>
> (1) we first wait for any direct I/O to complete to prevent any races
> for it
> (2) we then perform the actual zeroing, and only use the truncate_page
> helpers for truncating down. The truncate up case already is
> handled by the separate call to xfs_zero_eof.
> (3) only then we write back dirty data, as zeroing block may cause
> dirty pages when using either xfs_zero_eof or the new iomap
> infrastructure.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
> + * Start with zeroing any data beyond EOF that we may expose on file
> + & extension, or zeroing out the rest of the block on a downward
This "&" should be "*".
Reviewed-by: Bob Peterson <rpeterso at redhat.com>
More information about the xfs
mailing list