[PATCH] xfs: mute some sparse warnings

Christoph Hellwig hch at infradead.org
Fri Mar 25 13:07:19 CDT 2016


> @@ -478,7 +478,8 @@ xfs_inode_item_unpin(
>  STATIC uint
>  xfs_inode_item_push(
>  	struct xfs_log_item	*lip,
> -	struct list_head	*buffer_list)
> +	struct list_head	*buffer_list) __releases(&lip->li_ailp->xa_lock)
> +					      __acquires(&lip->li_ailp->xa_lock)

Can you move these down a bit?  Something like:

	struct list_head	*buffer_list)
		__releases(&lip->li_ailp->xa_lock)
		__acquires(&lip->li_ailp->xa_lock)
{

?

Otherwise looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list