[PATCH] xfs: fix computation of inode btree maxlevels

Christoph Hellwig hch at infradead.org
Wed Mar 2 03:45:20 CST 2016


On Tue, Mar 01, 2016 at 09:09:30PM -0800, Darrick J. Wong wrote:
> Commit 88740da18[1] introduced a function to compute the maximum
> height of the inode btree back in 1994.  Back then, apparently, the
> freespace and inode btrees shared the same geometry; however, it has
> long since been the case that the inode and freespace btrees have
> different record and key sizes.

I think that's always been the case, so this has been buggy since
day one.  Congrat for gfinding one of the probably oldest bugs so far!

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list