Some xfstests failures on non-crc xfs with latest xfsprogs (v4.5.0-rc1)

[Eric Sandeen]

On 3/4/16 5:23 AM, Eryu Guan wrote:
> Hi,
> 
> I noticed some xfstests failures while testing v4 XFS with latest
> v4.5.0-rc1 xfsprogs on v4.5-rc6 kernel, and all these failures are gone
> if I use v3.2.4 xfsprogs, or if test on v5 XFS.
> 
> So either xfstests needs update or xfsprogs breaks something for non-crc
> XFS. But I'm not sure which is which, so I post them out for broader
> review.
> 
> (All tests are checked with 'MKFS_OPTIONS="-m crc=0" ./check <sometest>')

Eryu, sorry you didn't get a reply on this in March.  We should have
listened!  ;)  The patches I sent in the pat day or two should
fix some of these ...

> == 1. xfs/032 fsck failure (xfs_db check) on ppc64 host ==

but not this one.  Do you still see this?

> == 2. xfs/033 fsck failure ==
> 
> xfs_repair detects more nlinks error. And this happens after commit
> "c2c5096 libxfs: update to 3.16 kernel code"

this should be fixed by
[PATCH] xfs_repair: set rsumino version to 2
 
> == 3. xfs/108 xfs/196 xfs/261 xfs/244 fsck failure. ==

this should be fixed by
[PATCH] xfs_repair: don't call xfs_sb_quota_from_disk twice

although I'm not sure about the ppc-specific failure.
 
> These tests fail in a similiar way, and they are all quota related.
> Note that xfs/244 only fails on ppc64, others fail on all arches.

> == 4. xfs/186 xfs/187 attr test failure ==
> 
> xfs/186 is missing almost all the attr values.

[PATCH] xfs/186: fix test for crc=0, ftype=1

> xfs/187 reports test needs update.

Not sure on this one yet.

-Eric