[PATCH] xfs/186: run test on expected XFS configuration

[Dave Chinner]

On Tue, Jun 21, 2016 at 08:01:47PM +0800, Eryu Guan wrote:
> Usually xfs/186 _notrun on crc enabled XFS because of
> _require_attr_v1, since v2 attr format is always enabled on v5 XFS.
> 
> But when testing on 512B block size XFS, i.e. MKFS_OPTIONS="-m crc=0
> -b size=512", test fails. This is because crc enalbed XFS was

*enabled

> created in the end, not 512B block size XFS with crc disabled, and
> that's not what we want to test.
> 
> The reason why _scratch_mkfs_xfs creates a different XFS than
> expected is that, it may ignore $MKFS_OPTIONS if mkfs fails due to
> conflicts between $MKFS_OPTIONS and the provided mkfs options.
> 
> In the case of xfs/186, "-b size=512" conflicts with "-i size=512",
> and the first mkfs fails, then it ends up with a 4k block size XFS
> with crc enabled (the default config).
> 
> Fix it by checking crc enablement status and attr version in the
> test, to make sure it's testing on expected XFS.
> 
> Signed-off-by: Eryu Guan <eguan at redhat.com>

Looks fine.

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com