[PATCH xfsprogs 2/2] linux.h: Define xfs_off_t as int64_t

Felix Janda felix.janda at posteo.de
Sat Jul 30 08:37:37 CDT 2016


int64_t is guaranteed to have the correct size and signedness and is
always avaible because linux.h has a <inttypes.h> include.

Fixes compilation error "unkown type name 'off64_t'" on linux when the
public header <xfs.h> is included without _LARGEFILE64_SOURCE or
_GNU_SOURCE defined. This bug was introduced in commit
cb898f157f8410a03cf5f3400baa1df9e5eecd33.

Signed-off-by: Felix Janda <felix.janda at posteo.de>
---
 include/linux.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux.h b/include/linux.h
index 5614719..7653cac 100644
--- a/include/linux.h
+++ b/include/linux.h
@@ -137,7 +137,7 @@ platform_discard_blocks(int fd, uint64_t start, uint64_t len)
 #define EFSCORRUPTED	EUCLEAN	/* Filesystem is corrupted */
 #define EFSBADCRC	EBADMSG	/* Bad CRC detected */
 
-typedef off64_t		xfs_off_t;
+typedef int64_t		xfs_off_t;
 typedef __uint64_t	xfs_ino_t;
 typedef __uint32_t	xfs_dev_t;
 typedef __int64_t	xfs_daddr_t;
-- 
2.7.3



More information about the xfs mailing list