[PATCH 0/2 v3] xfs: handle dquot buffer readahead in log recovery correctly
Dave Chinner
david at fromorbit.com
Sun Jan 10 21:24:52 CST 2016
Hi folks,
Version 3 of this patchset. Version 2 of the patchset added a fix
for the inode readahead error setting in log recovery, which turned
out to be problematic.
I've split that change out into it's own patch which includes the
fix it requires to prevent a race condition in log recovery to do
with inode buffer creation recovery. This is a generic fix to
xfs_buf_get_map(), in that if we are returning an initialised buffer
for the caller to use, it shouldn't have an error set on it from the
previous operation. If we don't clear the error before returning the
buffer, it causes unexpected failures further down the line. This
caused log recovery failures in generic/073 on slow disks (i.e.
needed sufficient readahead IO latency to open the race window) and
a couple of other tests as well.
The second patch is essentially the original patch with just the
inode buffer changes removed. There are no other changes to that
patch.
Cheers,
Dave.
More information about the xfs
mailing list