[PATCH 35/76] libxfs: refactor short btree block verification

Dave Chinner david at fromorbit.com
Sun Jan 3 15:30:38 CST 2016


On Sun, Jan 03, 2016 at 04:18:32AM -0800, Christoph Hellwig wrote:
> > +/**
> > + * xfs_btree_sblock_v5hdr_verify() -- verify the v5 fields of a short-format
> > + *				      btree block
> > + *
> > + * @bp: buffer containing the btree block
> > + * @max_recs: pointer to the m_*_mxr max records field in the xfs mount
> > + * @pag_max_level: pointer to the per-ag max level field
> > + */
> 
> We're so far avoided using kerneldoc comments and they silly super
> verbosity in XFS.  It might be good to tone this down to the normal
> XFS level (same for some other patches).

I'll do that before I commit it.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list