What is the meaning of XLOG_MIN_RECORD_BSIZE? (Missing a check?)

[Jan Tulak]

Hi guys,

what is the meaning of XLOG_MIN_RECORD_BSIZE in libxfs/xfs_log_format.h?
It is not used anywhere. I thought it might be related to -l su/sunit
option, but seeing tests with -l su=4096 (the macro is set to 16k), it
looks more like a forgotten value.

There is no check for a minimal value, so I can do -l su=1 (or su=0). Are
there some caveat​s (other than performance) with such a small value? Can
it be that we are missing a check? Because
XLOG_BIG_RECORD_BSIZE
​ and XLOG_MAX_RECORD_BSIZE are used and the upper bound is limited.​..


​Thanks​.

Cheers,
Jan

-- 
Jan Tulak
jtulak at redhat.com / jan at tulak.me
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20160219/6ffdd340/attachment.html>