[PATCH 1/3 V2] xfs: convert mount option parsing to tokens

Christoph Hellwig hch at infradead.org
Wed Feb 17 10:54:09 CST 2016


> -suffix_kstrtoint(char *s, unsigned int base, int *res)
> +suffix_kstrtoint(const substring_t *s, unsigned int base, int *res)
>  {
>  	int	last, shift_left_factor = 0, _res;
> -	char	*value = s;
> +	char	*value = match_strdup(s);
> +	int	ret = 0;
> +

Needs to check for a NULL return value.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list