[PATCH 11/15] xfs: move v1 inode conversion to xfs_inode_from_disk

[Dave Chinner]

On Wed, Feb 17, 2016 at 06:48:21PM +1100, Dave Chinner wrote:
> On Tue, Feb 16, 2016 at 11:32:04PM -0800, Christoph Hellwig wrote:
> > On Wed, Feb 17, 2016 at 06:20:48PM +1100, Dave Chinner wrote:
> > > +
> > > +	sbversion |= XFS_SB_VERSION_NLINKBIT;
> > > +	setlink_inode(id, be32_to_cpu(dip->di_nlink), type == DBM_DIR, security);
> > > +
> > 
> > So we always convert to v2 inodes here.  Given that's it's xfs_check
> > it's only in-core so harmless, but a comment here might be useful.
> 
> Yeah, probably. I'll have to look at this a bit closer - I think I
> assumed that we're always going to have v2 inode format here (like
> we do in the kernel), but that may not be true. I'll have a closer
> look.

having a closer look, the XFS_SB_VERSION_NLINKBIT that is set here
in sbversion is never used, so I just removed it. I also changed it
back to using the converted in-memory link count so it's always
going to be correct now. Now it is just:

+       setlink_inode(id, xino.i_d.di_nlink, type == DBM_DIR, security);

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com