Looks good, Reviewed-by: Christoph Hellwig <hch at lst.de> Tiny nitpick below: > out_error: > /* Now that the code below this label is more than just error handling it might make sense to rename it to just 'out'.