[PATCH 6/9] xfs: use vfs inode nlink field everywhere

Christoph Hellwig hch at infradead.org
Mon Feb 8 03:40:21 CST 2016


On Mon, Feb 08, 2016 at 03:24:18PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> The Vfs tracks the inodenlink just like the xfs_icdinode. We can

s/Vfs/VFS/

> +STATIC int
>  xfs_iunlink(
> -	xfs_trans_t	*tp,
> -	xfs_inode_t	*ip)
> +	struct xfs_trans *tp,
> +	struct xfs_inode *ip,
> +	bool		ignore_linkcount)

I'd say kill the ignore_linkcount parameter and the assert depending on it.
There are just two callers: xfs_droplink checks for i_nlink just before
the call, and xfs_create_tmpfile has to set the override flag.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the xfs mailing list